Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show msg on save #5269

Closed
wants to merge 4 commits into from
Closed

Show msg on save #5269

wants to merge 4 commits into from

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Sep 15, 2021

Details

#4491 (comment)

Fixed Issues

$ #4491

Tests || QA Steps

  1. Login to newDot
  2. Go to Workspace page
  3. Edit Workspace name
  4. Save and it'll show a growl

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web.mov

Mobile Web

mWeb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

Android.mov

@aman-atg aman-atg requested a review from a team as a code owner September 15, 2021 16:55
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team September 15, 2021 16:55
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change please 🙏

src/libs/actions/Policy.js Outdated Show resolved Hide resolved
Co-authored-by: Alex Beaman <dabeamanator@gmail.com>
@aman-atg
Copy link
Contributor Author

Updated

@kadiealexander
Copy link
Contributor

Hi @aman-atg, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

@aman-atg
Copy link
Contributor Author

Main merged!

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR is not needed anymore.

@aman-atg
Copy link
Contributor Author

oh yea... looks like this PR: #5759 was merged while the original PR was on n6-hold..

cc: @mallenexpensify @Beamanator

@Beamanator
Copy link
Contributor

Aah yep good call fellas. I'd say let's close this, I'll make a note in the issue that you should still get paid 👍

@Beamanator Beamanator closed this Oct 27, 2021
@aman-atg aman-atg deleted the showMsgOnSave branch October 27, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants